> On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java > > Lines 36 (patched) > > <https://reviews.apache.org/r/63502/diff/4/?file=1939505#file1939505line36> > > > > I am not sure what we mean here by local users.
These are the users connected to the local server > On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java > > Lines 48 (patched) > > <https://reviews.apache.org/r/63502/diff/4/?file=1939505#file1939505line48> > > > > I suggest changing the name so it indicates that instances are included This would be misleading because the instances that are exchanged are instances of selected types. > On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java > > Lines 51 (patched) > > <https://reviews.apache.org/r/63502/diff/4/?file=1939505#file1939505line51> > > > > I suggest removing classifications - as there is no instance of a > > classification without an entity. This would suggest that we would always exchange all types of classifications attached to an entity. This is a design change. > On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java > > Lines 53 (patched) > > <https://reviews.apache.org/r/63502/diff/4/?file=1939505#file1939505line53> > > > > I am unsure how this is different from LEARNED_TYPES. All means exchange all instances of any type; learned types means just exchange instances that are of types of interest by local users. With learned types - if the local users are not requesting metadata instances of a specific type, the instances of that type are not exchanged. All means theses instances would be exchange. > On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSEnterpriseConnectorManager.java > > Lines 34 (patched) > > <https://reviews.apache.org/r/63502/diff/4/?file=1939531#file1939531line34> > > > > I wonder if you could give an example of how an OMAS might call the > > OMRS - is it this class that is involved? It is not appropiate to describe the broader design in the header of a class. The header should describe the behaviour of > On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSEnterpriseConnectorManager.java > > Lines 83 (patched) > > <https://reviews.apache.org/r/63502/diff/4/?file=1939531#file1939531line83> > > > > do these need to be ordered or should theis be a Set They need to be ordered. > On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java > > Lines 41 (patched) > > <https://reviews.apache.org/r/63502/diff/4/?file=1939647#file1939647line41> > > > > Do we need Character? I could add character but Apache Atlas does not support character. > On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipCategory.java > > Lines 28 (patched) > > <https://reviews.apache.org/r/63502/diff/4/?file=1939648#file1939648line28> > > > > I suggest adding a clarifying comment around direction. As UML has > > bidirectional and directional associations. What would be in the clarifying comment? To say that all relationships are bi-drectional? This is what I have guessed you mean. > On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipCategory.java > > Lines 48 (patched) > > <https://reviews.apache.org/r/63502/diff/4/?file=1939648#file1939648line48> > > > > I suggest changing structure to entity here. Structure has echos of the > > Atlas structure - which could be misleading. ok - but structs are no longer part of the model and it seems a bit strange to remove the word from our vocabulary because of a feature that is not supported. > On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefPatch.java > > Lines 31 (patched) > > <https://reviews.apache.org/r/63502/diff/4/?file=1939654#file1939654line31> > > > > should we not allow relationshipdef changes such that they result in a > > deletion from an entitydef RelationshiphDefs can be deleted in a patch. The deletion of a relationship only changes the associated properties of the entity - not the entity itself. This modularization of the model is a key feature of our type system. > On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/CohortConnectionStatus.java > > Lines 29 (patched) > > <https://reviews.apache.org/r/63502/diff/4/?file=1939662#file1939662line29> > > > > I am not sure what this description means. I am not sure what messages > > the components of the cohort need to exchange with the cohort. Could change it to be "The local components for this cohort are initialized by they have not exchanged messages with other members of the cohort." > On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/CohortConnectionStatus.java > > Lines 45 (patched) > > <https://reviews.apache.org/r/63502/diff/4/?file=1939662#file1939662line45> > > > > I suggest having unique numbers of the enum statusCodes. lol - agreed > On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/OMRSCohortManager.java > > Lines 45 (patched) > > <https://reviews.apache.org/r/63502/diff/4/?file=1939663#file1939663line45> > > > > I am woindering if -the dtate is initialised to NEW - is uninitialised > > never used / not necessary. I can remove it > On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/OMRSCohortManager.java > > Lines 111 (patched) > > <https://reviews.apache.org/r/63502/diff/4/?file=1939663#file1939663line111> > > > > I wonder whether it would be better to set the status as initialising > > here. So if any of the listeners we register receive anything then they do > > not incorrectly see the state as error. I suggest setting the state as > > error in a catch when there is an actual error. This would not be right as there are many exceptions that are thrown during the processing and we want the status to be right if there is an error. Only if we get to the end of the processing is the status set to available. If we coded it the way you suggest, no processing would ever see the initializing status so it would be completely pointless. > On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/OMRSCohortManager.java > > Lines 282 (patched) > > <https://reviews.apache.org/r/63502/diff/4/?file=1939663#file1939663line282> > > > > It might be safer to now gobble this error and let is perculate up for > > now - so it is seen. Alternatively wrap it with one of our runtime > > Excpetions and ensure it is logged somewhere. This is a bit of a non-comment - the management of the error is down as a to do. > On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/OMRSMetadataHighwayManager.java > > Lines 47 (patched) > > <https://reviews.apache.org/r/63502/diff/4/?file=1939664#file1939664line47> > > > > I am wondering whether the cohort managers need to be ordered. If not > > this should be a Set. they need to be ordered. > On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/OMRSCohortRegistry.java > > Lines 425 (patched) > > <https://reviews.apache.org/r/63502/diff/4/?file=1939665#file1939665line425> > > > > I suggest we document what the implications of permanent=false are and > > when the caller should use each setting. Yes - this documentation belongs in the config guide. > On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/OMRSCohortRegistry.java > > Lines 432 (patched) > > <https://reviews.apache.org/r/63502/diff/4/?file=1939665#file1939665line432> > > > > I sugegst we have the cohort status as discconnecting here. So we can > > manage events if they come in in this state. The disconnecting status would never been seen since the disconnect processes happen in one method/thread. Events are no longer processed once the topic is disconnected. You are talking about a time window of a fer hundred Java statements - Mandy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195417 ----------------------------------------------------------- On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63502/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2018, 1:35 p.m.) > > > Review request for atlas, David Radley and Madhan Neethiraj. > > > Repository: atlas > > > Description > ------- > > This is a request for code review of the OMRS. There are still parts of the > code not written - the aim of the review is to make the connector interfaces > available so they can be evaluated by teams buinding components against the > APIs. > > There is a patch connected to > https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the > code plus other code that is not ready for review. The OMRS Connector API > depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095. > > > Diffs > ----- > > omrs/README.md PRE-CREATION > omrs/pom.xml PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditCode.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditLog.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditLogRecordSeverity.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditingComponent.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogRecord.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogRecordOriginator.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogReportingComponent.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogStore.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogStoreConnectorBase.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogStoreProviderBase.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/file/FileBasedAuditLogStoreConnector.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/file/FileBasedAuditLogStoreProvider.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSConnectionConsumer.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSConnectorConsumer.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSConnectorManager.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSEnterpriseConnectorManager.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSConnectorProperties.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSConnectorProvider.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSMetadataCollection.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSRepositoryConnector.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSEventListener.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSEventPublisher.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventExchangeRule.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventManager.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventProcessor.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSEvent.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSEventCategory.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSEventDirection.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSEventErrorCode.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSEventOriginator.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSInstanceEvent.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSInstanceEventErrorCode.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSInstanceEventProcessor.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSInstanceEventType.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSRegistryEvent.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSRegistryEventErrorCode.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSRegistryEventProcessor.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSRegistryEventType.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSTypeDefEvent.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSTypeDefEventErrorCode.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSTypeDefEventProcessor.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSTypeDefEventType.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/v1/OMRSEventV1.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/v1/OMRSEventV1ErrorSection.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/v1/OMRSEventV1InstanceSection.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/v1/OMRSEventV1RegistrySection.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/v1/OMRSEventV1TypeDefSection.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/repositoryeventmapper/OMRSRepositoryEventMapper.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/repositoryeventmapper/OMRSRepositoryEventMapperBase.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/repositoryeventmapper/OMRSRepositoryEventMapperProviderBase.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSErrorCode.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/README.md PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/ClassificationNotKnownException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/EntityConflictException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/EntityNotDeletedException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/EntityNotKnownException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/HomeEntityException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/HomeRelationshipException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/InvalidEntityException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/InvalidRelationshipException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/InvalidTypeDefException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/NotImplementedRuntimeException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/OMRSCheckedExceptionBase.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/OMRSConfigErrorException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/OMRSLogicErrorException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/OMRSRuntimeException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/PagingErrorException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/PatchErrorException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/PropertyErrorException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/RelationshipConflictException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/RelationshipKnownException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/RelationshipNotDeletedException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/RelationshipNotKnownException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/RepositoryErrorException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/StatusNotSupportedException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/TypeDefConflictException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/TypeDefInUseException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/TypeDefKnownException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/TypeDefNotKnownException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/TypeErrorException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/OMRSLocalRepository.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSConnectorProvider.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSInstanceEventProcessor.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSRepositoryConnector.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSInstanceHelper.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSInstanceRetrievalEventProcessor.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSInstanceValidator.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSRepositoryContentManager.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSRepositoryHelper.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSRepositoryValidator.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefHelper.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefManager.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefValidator.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollection.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollectionBase.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/MatchCriteria.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/SequencingOrder.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/ArrayPropertyValue.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classification.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/ClassificationOrigin.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityDetail.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityProxy.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummary.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityUniverse.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EnumPropertyValue.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceElementHeader.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceGraph.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceHeader.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceProperties.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstancePropertyCategory.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstancePropertyValue.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceProvenanceType.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceStatus.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceType.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/MapPropertyValue.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/PrimitivePropertyValue.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationship.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/StructPropertyValue.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeCardinality.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeTypeDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationPropagationRule.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDefCategory.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EntityDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumElementDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ExternalStandardMapping.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipCategory.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipEndDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefCategory.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefElementHeader.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefPatch.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefPatchAction.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefProperties.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefSummary.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSConnection.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSMetadataCollectionProvider.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSRepositoryConnector.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSRepositoryConnectorProviderBase.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/CohortConnectionStatus.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/OMRSCohortManager.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/OMRSMetadataHighwayManager.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/OMRSCohortRegistry.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/OMRSCohortRegistryStore.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/OMRSCohortRegistryStoreConnectorBase.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/OMRSCohortRegistryStoreProviderBase.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/file/FileBasedRegistryStoreConnector.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/file/FileBasedRegistryStoreProvider.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/properties/CohortMembership.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/properties/MemberRegistration.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/rest/repositoryconnector/OMRSRESTMetadataCollection.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/rest/repositoryconnector/OMRSRESTRepositoryConnector.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/rest/repositoryconnector/OMRSRESTRepositoryConnectorProvider.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/OMRSTopic.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/OMRSTopicConnector.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/OMRSTopicListener.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/kafka/KafkaOMRSTopicConnector.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/kafka/KafkaOMRSTopicProvider.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/63502/diff/4/ > > > Testing > ------- > > There are samples of OMRS Connectors (without the metadata collection > implementations). > > > File Attachments > ---------------- > > 0002-ATLAS-2246-OMRS-Connector-API-plus-REST-and-IGC-Conn.patch > > https://reviews.apache.org/media/uploaded/files/2017/11/10/f6618d2e-681e-4f04-bc06-35324a341474__0002-ATLAS-2246-OMRS-Connector-API-plus-REST-and-IGC-Conn.patch > 0002-ATLAS-2246-code-review-version.patch > > https://reviews.apache.org/media/uploaded/files/2018/01/12/44ae6cd8-260d-4687-8563-a46e6b120fc6__0002-ATLAS-2246-code-review-version.patch > > > Thanks, > > Mandy Chessell > >
