----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62175/#review195963 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java Line 138 (original), 167 (patched) <https://reviews.apache.org/r/62175/#comment275424> Consider using Collections.unmodifiableSet() instead of ImmutableSet. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java Lines 257 (patched) <https://reviews.apache.org/r/62175/#comment275425> Please review if indexes are created for relationship attributes. webapp/src/main/java/org/apache/atlas/web/rest/RelationshipREST.java Line 71 (original) <https://reviews.apache.org/r/62175/#comment275426> This file has only white space changes. Please review and revert if there are no other changes. - Madhan Neethiraj On Jan. 22, 2018, 11:09 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62175/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2018, 11:09 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-2119 > https://issues.apache.org/jira/browse/ATLAS-2119 > > > Repository: atlas > > > Description > ------- > > * Implement update and delete relationship in RelationshipREST > * Add propagateTags information to each relationship instance > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f8829b57 > intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java > 1f459db7 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 4da74b94 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java > 6a6ac603 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java > 9301cfaa > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > b0940f67 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > e7cd51a4 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java > b418fef9 > webapp/src/main/java/org/apache/atlas/web/rest/RelationshipREST.java > 0ee14cb9 > > > Diff: https://reviews.apache.org/r/62175/diff/6/ > > > Testing > ------- > > validated using POSTMAN Rest client. > > Integration/Unit Tests in progress > > > Thanks, > > Sarath Subramanian > >
