-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65583/#review197219
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On Feb. 9, 2018, 6:06 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65583/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2018, 6:06 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Ruchi Solani, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2435
>     https://issues.apache.org/jira/browse/ATLAS-2435
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Updated relationship instance create/update flow to avoid duplicate queries 
> to retrive vertices
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 7d88547c 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> 1920eda1 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> 94b0d22e 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 
> a9912fb4 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> 41061bc8 
>   intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 5e30554f 
>   intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 1039de66 
>   intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> e39089c3 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 9af1d651 
>   intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 1fdee837 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 
> aa26d186 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 1c202e7c 
>   intg/src/main/java/org/apache/atlas/type/AtlasType.java 47db2c0e 
>   intg/src/main/java/org/apache/atlas/utils/AtlasEntityUtil.java e237e86d 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasRelationshipStore.java
>  80437601 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java
>  4c511c1d 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
>  db7594d6 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
>  1cada0b6 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  c203ff42 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityMutationContext.java
>  df5bd093 
> 
> 
> Diff: https://reviews.apache.org/r/65583/diff/2/
> 
> 
> Testing
> -------
> 
> These updates save about 10% of the avg.time in processing about 6500 
> messages (655ms vs 577ms). A lot more performance improvement is needed 
> though. We will explore more.
> 
> This patch also includes few fixes/additions to validation.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Reply via email to