----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65647/#review197481 -----------------------------------------------------------
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java Lines 222 (patched) <https://reviews.apache.org/r/65647/#comment277649> Consider replacing 'config.get("HdfsBolt.fsUrl") + hdfsUri' with 'hdfsPathStr' - which was assigned in previous line. common/src/main/java/org/apache/atlas/utils/HdfsNameServiceResolver.java Lines 127 (patched) <https://reviews.apache.org/r/65647/#comment277650> shouldn't "ret = uri.getHost()" be "ret = reverseNameServiceMapping.get(uri.getHost())"? - Madhan Neethiraj On Feb. 14, 2018, 4:49 a.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65647/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2018, 4:49 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-2444 > https://issues.apache.org/jira/browse/ATLAS-2444 > > > Repository: atlas > > > Description > ------- > > See ATLAS-2444 > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java > 7cca48f11 > > addons/models/1000-Hadoop/patches/005-hdfs_path_add_nameServiceId_attribute.json > PRE-CREATION > > addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java > 57fc7a1fd > common/pom.xml a7ab6a312 > common/src/main/java/org/apache/atlas/utils/HdfsNameServiceResolver.java > PRE-CREATION > > common/src/test/java/org/apache/atlas/utils/HdfsNameServiceResolverTest.java > PRE-CREATION > common/src/test/resources/atlas-log4j.xml PRE-CREATION > common/src/test/resources/hdfs-site.xml PRE-CREATION > pom.xml c15e0dad7 > > > Diff: https://reviews.apache.org/r/65647/diff/1/ > > > Testing > ------- > > mvn clean package executes successfully. > > The modified war was tested on a multi-node cluster with one nameServiceId > and 2 NameNodes, the required information was captured successfully in the > entity when an external table was created from beeline (hive context) > > > Thanks, > > Apoorv Naik > >
