-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65659/
-----------------------------------------------------------
Review request for atlas and Apoorv Naik.
Bugs: ATLAS-2447
https://issues.apache.org/jira/browse/ATLAS-2447
Repository: atlas
Description
-------
**Background**
Within _GremlinQueryComposer_ the gremlin query construction used a combination
of _limit_ and _limit-local_ for limiting results. This caused some scenarios
to fail. See bug for details.
Also, if there was any exception within the Gremlin script engine, it would not
display the exact cause of the failure. This caused users not to know the
exact problem with the constructed query.
**Approach**
* _GremlinClause_: Replaced _limit-local_ with _dedup_.
* Added exception handling to display cause of exception if available.
Diffs
-----
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
4a18ed13
repository/src/main/java/org/apache/atlas/query/GremlinClause.java c770f77e
repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java
92029f56
repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 82b73812
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java
85addc26
Diff: https://reviews.apache.org/r/65659/diff/1/
Testing
-------
**Unit tests**
- Additional tests added to verify error scenarios when comparing floats with
values larger than max float.
- Updated unit tests to reflect the new _dedup_ usage within the query
composition.
**Functional tests**
- Executed scenarios to view new error messages.
Thanks,
Ashutosh Mestry
