----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65737/ -----------------------------------------------------------
Review request for atlas and Madhan Neethiraj. Repository: atlas Description ------- With previous implementation the serializer code was updated to not serialize null values this led to a side-effect on the client side, when an attribute had to be explicitly set to null. The client would not serialize the null into the JSON and the server would not see any difference in the requested entity change hence it would skip setting the null. This changeset reverts the serialization changes and adds some special handling around the DELETEd entities in the notification layer Diffs ----- repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java 153052560 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java ebce279d8 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java ad8ab8e4d repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java d3df4642f repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 6132cb062 server-api/src/main/java/org/apache/atlas/RequestContextV1.java 08aa9606a typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java d939a9b8a webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java 53acf5631 Diff: https://reviews.apache.org/r/65737/diff/1/ Testing ------- PreCommit is failing with same errors as on branch-0.8 https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/108/ Thanks, Apoorv Naik
