-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65870/#review198479
-----------------------------------------------------------
Few more places to replace text "tag" with "classification":
1. page that list entities for a tag (/tag/tagAttribute/):
label "Direct sub-tags" ==> "Direct sub-classifications"
column title "Tags" => "Classifications"
2. Basic search controls:
"Search By Tag" ==> "Search By Classification"
3. Basic search result page:
column title "Tags" ==> "Classifications"
Results for: "Tag:" ==> "Classification:"
4. DSL result page:
column title "Tags" ==> "Classifications"
5. Others:
"Exclude sub-type" ==> "Exclude sub-types"
"Exclude sub-classification" ==> "Exclude sub-classifications"
dashboardv2/public/js/templates/tag/AddTagModalView_tmpl.html
Line 21 (original), 23 (patched)
<https://reviews.apache.org/r/65870/#comment278627>
'Select' currently exludes propagated classifications as well; only
directly associated classifications should be excluded in the list.
dashboardv2/public/js/templates/tag/AddTagModalView_tmpl.html
Lines 30 (patched)
<https://reviews.apache.org/r/65870/#comment278624>
- name, value attributes appear twice in line #30, #37
- for 'Propagate' checkbox, default should be 'checked'
- Madhan Neethiraj
On March 1, 2018, 8:41 p.m., pratik pandey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65870/
> -----------------------------------------------------------
>
> (Updated March 1, 2018, 8:41 p.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and
> Sarath Subramanian.
>
>
> Bugs: ATLAS-2469
> https://issues.apache.org/jira/browse/ATLAS-2469
>
>
> Repository: atlas
>
>
> Description
> -------
>
> User Story:
>
> As a data steward i need a scalable way to quickly and efficiently propagate
> tags for efficient searches and tag based security. Likewise tags for
> derivative dataset should be inherited from the parent. For example, if an
> entity is tagged "Secret" then resulting entity created from a CTAS operation
> should also be tagged "secret" to maintain the classification of the parent.
> In the case where 2 or more datasets are aggregated the derivative dataset
> should be a union of all parent tags.
>
> Terms:
>
> Child business terms should inherit the tags associated with the parent term.
> the option to propagate tags to child business terms in a hierarchy should be
> provided
> Ability to update the propagated tags manually via UI or through the API
> Tagging a term should propagate to data assets that are already attached to
> that business term as well
> Data assets
>
> For supported components in HDP 2.6,if a derivative asset is created it
> should inherit the tags and attributes from the original asset.
> the option to propagate tags to child entities should be provided (e.g. if
> you tag a hdfs folder optionally tag all the files within it)
> Ability to update the propagated tags manually via UI or through the API
> Tagging a parent object should be inherited even after child creation
> dynamically (unless a flag is set not to do this)
> Derived data assets should have the tags of the original data asset.
> conflict resolution - if the different values for attributes then a UX dialog
> that prompts user for action needs to be provided. Once resolved, the
> resolved value will be carry forth to derivative dataset.
>
>
> Diffs
> -----
>
> dashboardv2/gruntfile.js 451a933
> dashboardv2/package.json 9237c35
> dashboardv2/public/css/scss/override.scss f1e2c6b
> dashboardv2/public/js/main.js ce0f4fe
> dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html
> 1578548
> dashboardv2/public/js/templates/site/SideNavLayoutView_tmpl.html b706609
> dashboardv2/public/js/templates/tag/AddTagModalView_tmpl.html a477532
> dashboardv2/public/js/templates/tag/AddTimezoneView_tmpl.html PRE-CREATION
> dashboardv2/public/js/templates/tag/TagDetailTableLayoutView_tmpl.html
> 76f225a
> dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 802f6a4
> dashboardv2/public/js/views/tag/AddTagModalView.js d1c8c67
> dashboardv2/public/js/views/tag/AddTimezoneItemView.js PRE-CREATION
> dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js c05b48d
>
>
> Diff: https://reviews.apache.org/r/65870/diff/1/
>
>
> Testing
> -------
>
> Done one round of sanity testing.
>
>
> Thanks,
>
> pratik pandey
>
>
