----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65902/#review198643 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On March 5, 2018, 12:23 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65902/ > ----------------------------------------------------------- > > (Updated March 5, 2018, 12:23 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2477 > https://issues.apache.org/jira/browse/ATLAS-2477 > > > Repository: atlas > > > Description > ------- > > 1. Created an Hive table "employee" and CTAS table "employee_ctas". > 2. Associated a tag tag1 to employee.Both employee and employee_ctas are > associated to tag1. > 3. Basic search with classification = tag1 , listed 3 entities - employee , > employee_ctas and the process. > 4. But Search with classification = tag1 , type = hive_table listed only the > employee . Expected that it would list the employee_ctas also. > 5.With Advanced search, both the following queries > > query =tag1 > typename = hive_table query = isa tag1 > > lists only the employee entity. > > Hence , search with type and tag lists only the entity to which the tag is > associated and not the propagated associations. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 4265e098 > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > 016ad1b9 > repository/src/main/java/org/apache/atlas/query/GremlinClause.java 38411037 > repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java > 9a66636d > > repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java > 65b99cd0 > repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java > fedb8a7e > > repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java > 9c8aac5c > > > Diff: https://reviews.apache.org/r/65902/diff/2/ > > > Testing > ------- > > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/138/console > > > Thanks, > > Sarath Subramanian > >
