----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65946/#review198877 -----------------------------------------------------------
Ship it! Ship It! - keval bhatt On March 7, 2018, 10:42 a.m., pratik pandey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65946/ > ----------------------------------------------------------- > > (Updated March 7, 2018, 10:42 a.m.) > > > Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and > Sharmadha Sainath. > > > Bugs: ATLAS-2482 > https://issues.apache.org/jira/browse/ATLAS-2482 > > > Repository: atlas > > > Description > ------- > > 1. Created a table and a view from the table. > 2.Associated a tag to table with propagate set to False. > 3.Edited the tag attribute associated to table. Since propagate is set to > False initially , propagate check box was unchecked. But request is sent with > default value True. > 4. If check box value is toggled from > unchecked to checked and then checked to unchecked , propagate is set to > False correctly. > 5. Thus , If no action is done on propagate check box , though it is > unchecked , the request is sent as "propagate" : True. > > > Diffs > ----- > > dashboardv2/public/js/views/tag/AddTagModalView.js 43bb7dd > > > Diff: https://reviews.apache.org/r/65946/diff/1/ > > > Testing > ------- > > Done one round of sanity testing. > > > Thanks, > > pratik pandey > >
