-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65999/#review198996
-----------------------------------------------------------


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java
Lines 237 (patched)
<https://reviews.apache.org/r/65999/#comment279271>

    Consider replacing use of parameters 'direction' and 'isInputEdge' with 
edge label name, as shown below:
    
    boolean isInputEdge  = 
edge.getLabel().equalsIgnoreCase(PROCESS_INPUTS_EDGE);
    
    if (isInputEdge) {
      relations.add(new LineageRelation(inGuid, outGuid, relationGuid));
    } else {
      relations.add(new LineageRelation(outGuid, inGuid, relationGuid));
    }


- Madhan Neethiraj


On March 11, 2018, 4:47 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65999/
> -----------------------------------------------------------
> 
> (Updated March 11, 2018, 4:47 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2489
>     https://issues.apache.org/jira/browse/ATLAS-2489
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java 
> a2e1b5e8f 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 
> ec4125dab 
>   
> repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java
>  58e3492e0 
> 
> 
> Diff: https://reviews.apache.org/r/65999/diff/2/
> 
> 
> Testing
> -------
> 
> PreCommit : 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/152/
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Reply via email to