-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66027/#review199003
-----------------------------------------------------------




addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
Line 321 (original), 348 (patched)
<https://reviews.apache.org/r/66027/#comment279281>

    V2 APIs don't allow 'AtlasEntity' in attributes.
    - use AtlasEntitiesWithExtInfo as type for 'lineageProcess'
    - replace AtlasEntity/List<AtlasEntity> in attributes with 
AtlasObjectId/List<AtlasObjectId>
    - add AtlasEntity instances in lineageProcess.referredEntities
    
    registerInstance() should take AtlasEntitiesWithExtInfo as argument type.


- Madhan Neethiraj


On March 12, 2018, 4:24 a.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66027/
> -----------------------------------------------------------
> 
> (Updated March 12, 2018, 4:24 a.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2491
>     https://issues.apache.org/jira/browse/ATLAS-2491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-2491:Atlas Hive hook should use atlas v2 api for Entity propagation
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/pom.xml 14e4295 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  4047c16 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java
>  PRE-CREATION 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 69d294c 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterDatabase.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTable.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRenameCol.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AtlasEvent.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/DropDatabase.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/DropTable.java
>  PRE-CREATION 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 
> 217c6aa 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveLiteralRewriterTest.java
>  f4abfb6 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java
>  ea669f3 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetastoreBridgeIT.java
>  22d3c59 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> f96d47d 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java fce46da 
> 
> 
> Diff: https://reviews.apache.org/r/66027/diff/1/
> 
> 
> Testing
> -------
> 
> Tested in local vm
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Reply via email to