----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66087/#review199319 -----------------------------------------------------------
Ship it! Ship It! - Nixon Rodrigues On March 15, 2018, 12:34 p.m., pratik pandey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66087/ > ----------------------------------------------------------- > > (Updated March 15, 2018, 12:34 p.m.) > > > Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues. > > > Bugs: ATLAS-2501 > https://issues.apache.org/jira/browse/ATLAS-2501 > > > Repository: atlas > > > Description > ------- > > 1. Created 2 Hive tables > a.test_table > b.test_table_ctas (CTAS of test_table) > 2. Created a tag and associated the tag to test_table with propagate set to > True. > 3. Basic search for the tables listed test_table_ctas with PII tag and remove > button. On the detailsPage of test_table_ctas , remove button is not present. > > > Diffs > ----- > > dashboardv2/public/css/scss/form.scss 0765dde > dashboardv2/public/js/utils/CommonViewFunction.js 47e50d6 > dashboardv2/public/js/views/search/SearchResultLayoutView.js ccc666b > > > Diff: https://reviews.apache.org/r/66087/diff/1/ > > > Testing > ------- > > Done one round of sanity testing. > > > Thanks, > > pratik pandey > >
