----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66151/#review199482 -----------------------------------------------------------
Fix it, then Ship it! addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java Line 380 (original), 380 (patched) <https://reviews.apache.org/r/66151/#comment279789> The format specifications are used in several places. Please consider replacing them with public static final String HBASE_TABLE_QUALIFIED_NAME_FORMAT = "%s:%s@%s"; public static final String HBASE_COLUMN_FAMILY_QUALIFIED_NAME_FORMAT = "%s:%s.%s@%s"; in HBaseAtlasHook class. - Abhay Kulkarni On March 19, 2018, 9:44 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66151/ > ----------------------------------------------------------- > > (Updated March 19, 2018, 9:44 p.m.) > > > Review request for atlas, Abhay Kulkarni and Madhan Neethiraj. > > > Bugs: ATLAS-2507 > https://issues.apache.org/jira/browse/ATLAS-2507 > > > Repository: atlas > > > Description > ------- > > ATLAS-2507 : HBase hook for Atlas should have QualifiedName with ":" as > suffix for Namespace instead of "." > > > Diffs > ----- > > > addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java > f165e98 > > addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntitiesBase.java > d11a1a0 > > > Diff: https://reviews.apache.org/r/66151/diff/1/ > > > Testing > ------- > > Verified in Local VM > > > Thanks, > > Ramesh Mani > >
