----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66194/#review199988 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On March 21, 2018, 12:16 p.m., pratik pandey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66194/ > ----------------------------------------------------------- > > (Updated March 21, 2018, 12:16 p.m.) > > > Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and > Sharmadha Sainath. > > > Bugs: ATLAS-2508 > https://issues.apache.org/jira/browse/ATLAS-2508 > > > Repository: atlas > > > Description > ------- > > When Apply Validity Period check box is checked , default value for start > time and end time is applied > Example : 2018/03/20 2:18 PM - 2018/03/20 11:59 PM (i.e) > Start time : Today's Date Current time > End time : Todays's Date 11:59 PM > > and no timezone is selected by default. > > But the POST request is sent as > "validityPeriods":[ > > {"startTime":"","endTime":"","timeZone":""} > ]} > > > Diffs > ----- > > dashboardv2/public/js/views/tag/AddTimezoneItemView.js 420303f > > > Diff: https://reviews.apache.org/r/66194/diff/3/ > > > Testing > ------- > > Done one round of sanity testing. > > > Thanks, > > pratik pandey > >
