----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65435/ -----------------------------------------------------------
(Updated March 29, 2018, 2:33 p.m.) Review request for atlas and Mandy Chessell. Changes ------- update code based on reviews Repository: atlas Description ------- This is the new review request for ATLAS-2298 OCF Database Connector. The old review on [https://reviews.apache.org/r/65123/](https://reviews.apache.org/r/65123/) will not be updated anymore. The OCF Database Connector is the subclass of OCF Connector and it is designed especially for connection to database to retrieve data. Here we implement a connector for Gaian (GaianOCFConnector) as an example for using OCF Database Connector. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298 Diffs (updated) ----- ocf-database-connector/README.md PRE-CREATION ocf-database-connector/pom.xml PRE-CREATION ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/connectors/OCFDatabaseConnection.java PRE-CREATION ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/connectors/OCFDatabaseConnector.java PRE-CREATION ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/connectors/OCFDatabaseConnectorProviderBase.java PRE-CREATION ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/connectors/gaian/GaianOCFConnector.java PRE-CREATION ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/connectors/gaian/GaianOCFConnectorProvider.java PRE-CREATION ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/ffdc/DatabaseConnectCheckedException.java PRE-CREATION ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/ffdc/OCFDatabaseCheckedExceptionBase.java PRE-CREATION ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/ffdc/OCFDatabaseConnectorErrorCode.java PRE-CREATION ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/ffdc/OCFDatabaseConnectorRuntimeException.java PRE-CREATION ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/util/PropertiesHelper.java PRE-CREATION ocf-database-connector/src/main/resources/gaian.properties PRE-CREATION ocf-database-connector/src/test/java/gaianocfconnector/GaianOCFConnectorTest.java PRE-CREATION ocf-database-connector/src/test/java/gaianocfconnector/UseGaianOCFConnector.java PRE-CREATION pom.xml ee2746a905f84359d426acfb1fa6d64c6310aaaf Diff: https://reviews.apache.org/r/65435/diff/3/ Changes: https://reviews.apache.org/r/65435/diff/2-3/ Testing ------- see test folder. Gaian has to set up in advance File Attachments ---------------- 0005-ATLAS-2298-05-Feb-code-review.patch https://reviews.apache.org/media/uploaded/files/2018/02/05/292c1917-9deb-4ced-8bd6-1689fc45fbd4__0005-ATLAS-2298-05-Feb-code-review.patch Thanks, Yao Li