----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66374/#review200231 -----------------------------------------------------------
addons/models/0000-Area0/0010-base_model.json Line 205 (original), 205 (patched) <https://reviews.apache.org/r/66374/#comment280891> I suggest there may be migration implications to renaming these base types. I suggest versioning this change. addons/models/0300-Area3-SubjectArea/0310-Glossary.json Lines 89 (patched) <https://reviews.apache.org/r/66374/#comment280889> I thought that we were thinking of these constraints as legacy and had assumed that we would not be adding any new ones. Doesn't the owned constraint imply that this is a one directional relationship, but the relationship definition is bidirectional. What does it mean that there is an attribute that uses the contraint but is not marked as legacy? I am wondering what we gain by adding the attribute in this way? addons/models/0300-Area3-SubjectArea/0320-CategoryHierarchy.json Lines 32 (patched) <https://reviews.apache.org/r/66374/#comment280890> I wonder why we are adding legacy attributes. I can see it gives us a manditory parent; I thought the relationship design was such that we were dropping this capability. - David Radley On March 30, 2018, 8:16 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66374/ > ----------------------------------------------------------- > > (Updated March 30, 2018, 8:16 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-2526 > https://issues.apache.org/jira/browse/ATLAS-2526 > > > Repository: atlas > > > Description > ------- > > - fixed incorrect syntax/braces in 0120-Collections.json that resulted in > relationshipDefs not to be loaded > - renamed sourceToProcesses as inputToProcess and sinkFromProcesses as > outputFromProcess > - added terms and categories as direct attributes of Glossary > - added anchor, parentCategory and childrenCategories as direct attributes of > GlossaryCategory > - added anchor as direct attribute of GlossaryTerm > > > Diffs > ----- > > addons/models/0000-Area0/0010-base_model.json aebe955d > addons/models/0100-Area1-Collaboration/0120-Collections.json 4dbd2adb > addons/models/0300-Area3-SubjectArea/0310-Glossary.json cac2ce2a > addons/models/0300-Area3-SubjectArea/0320-CategoryHierarchy.json 10637970 > addons/models/0300-Area3-SubjectArea/0330-Terms.json f492ddfd > > > Diff: https://reviews.apache.org/r/66374/diff/1/ > > > Testing > ------- > > Verified Atlas server starts up successfully with updated models > > > Thanks, > > Madhan Neethiraj > >
