-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66469/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik and Madhan Neethiraj.
Bugs: ATLAS-2532
https://issues.apache.org/jira/browse/ATLAS-2532
Repository: atlas
Description
-------
**Background**
Advanced Searche queries with Float.MAX_VALUE in comparision clause causes the
literal to be treated as _BigDecimal_, this causes error in execution.
**Approach**
Using the Java [[data
type][https://docs.oracle.com/javase/tutorial/java/nutsandbolts/datatypes.html]]
treatment approach. The generated Gremlin query containing float, double and
long will have the explicit specification.
E.g.
Query like: _g.V().has('__typeName', 'hdfs_path').has('hdfs_path.retention',
lte(3.4028235e+38)).dedup().limit(25).toList()_
Will now be: _g.V().has('__typeName', 'hdfs_path').has('hdfs_path.retention',
lte(3.4028235e+38f)).dedup().limit(25).toList()_
Diffs
-----
repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java
a0fb772e
repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java
96e7e9c7
repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 5df0308c
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java
fa2332e6
Diff: https://reviews.apache.org/r/66469/diff/1/
Testing
-------
**Unit tests**
- Updated existing tests.
- Added new tests.
Thanks,
Ashutosh Mestry
