[ 
https://issues.apache.org/jira/browse/ATLAS-2533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428084#comment-16428084
 ] 

Graham Wallis commented on ATLAS-2533:
--------------------------------------

Thanks for the speedy patch :) 

[~bpgergo] - I think the only use of this method may be from my (forthcoming) 
connector code.

> AtlasEntity is double classified
> --------------------------------
>
>                 Key: ATLAS-2533
>                 URL: https://issues.apache.org/jira/browse/ATLAS-2533
>             Project: Atlas
>          Issue Type: Bug
>            Reporter: Graham Wallis
>            Assignee: Sarath Subramanian
>            Priority: Major
>             Fix For: 1.0.0
>
>         Attachments: ATLAS-2533.1.patch
>
>
> When a list of classifications is added to an AtlasEntity, it gets added 
> twice due to the following:
> public void addClassifications(List<AtlasClassification> classifications) {
>  List<AtlasClassification> c = this.classifications;
>  if (c == null) {
>  c = new ArrayList<>(classifications);
>  this.classifications = c;
>  }
>  c.addAll(classifications);
> }
> This last line should be protected by an else clause.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to