-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66478/#review200693
-----------------------------------------------------------




addons/models/0000-Area0/0010-base_model.json
Line 2 (original), 2 (patched)
<https://reviews.apache.org/r/66478/#comment281544>

    This file has only white-space changes. Please revert.



addons/models/0000-Area0/0011-glossary_model.json
Lines 88 (patched)
<https://reviews.apache.org/r/66478/#comment281545>

    There is no unique attribute defined for entity types __AtlasGlossary, 
__AtlasGlossaryTerm and __AtlasGlossaryCategory. Consider adding 
'qualifiedName' attribute with isUnique=true.



intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java
Lines 342 (patched)
<https://reviews.apache.org/r/66478/#comment281546>

    assignedTerms ==> meanings


- Madhan Neethiraj


On April 7, 2018, 12:48 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66478/
> -----------------------------------------------------------
> 
> (Updated April 7, 2018, 12:48 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2534
>     https://issues.apache.org/jira/browse/ATLAS-2534
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Glossary implementation, no UI
> 
> 
> Diffs
> -----
> 
>   addons/models/0000-Area0/0010-base_model.json aebe955db 
>   addons/models/0000-Area0/0011-glossary_model.json PRE-CREATION 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
>  7bdbeabf0 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/NativeTinkerpopGraphQuery.java
>  75665592e 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java
>  96b9705fa 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/expr/OrderByPredicate.java
>  PRE-CREATION 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
>  6820a93c2 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java
>  d3c976df5 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java
>  2903ae228 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 997ac68fb 
>   intg/src/main/java/org/apache/atlas/model/AtlasBaseModelObject.java 
> 688f6f4d2 
>   intg/src/main/java/org/apache/atlas/model/annotation/AtlasJSON.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossary.java 
> PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryBaseObject.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryCategory.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 
> PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermAssignmentStatus.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermRelationshipStatus.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryHeader.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedCategoryHeader.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermHeader.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermAssignmentHeader.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermCategorizationHeader.java
>  PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> 395431922 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 
> 576847f6e 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 
> 61168f63f 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/ogm/AbstractDataTransferObject.java
>  f1a8bc91d 
>   
> repository/src/main/java/org/apache/atlas/repository/ogm/AtlasSavedSearchDTO.java
>  a1a8f598d 
>   
> repository/src/main/java/org/apache/atlas/repository/ogm/AtlasUserProfileDTO.java
>  bcf2b9d27 
>   repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java 
> 818960d96 
>   repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java 
> c99d2f836 
>   
> repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AbstractGlossaryDTO.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryCategoryDTO.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java
>  b9945d4fc 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
>  13ee2a6df 
>   
> repository/src/main/java/org/apache/atlas/repository/userprofile/UserProfileService.java
>  a428b92ee 
>   repository/src/test/java/org/apache/atlas/TestModules.java c901e891c 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 
> PRE-CREATION 
>   
> repository/src/test/java/org/apache/atlas/glossary/PaginationHelperTest.java 
> PRE-CREATION 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java
>  d8e916d77 
>   
> repository/src/test/java/org/apache/atlas/repository/userprofile/UserProfileServiceTest.java
>  8e19f79e8 
>   
> webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
>  01a95cf80 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66478/diff/5/
> 
> 
> Testing
> -------
> 
> Added test GlossaryServiceTest, runs successfully.
> 
> mvn clean package executes successfully.
> 
> PreCommit: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/236/
>  (in-progress)
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Reply via email to