I could swear I had uploaded the diff to the review board. I updated the review with the diff, and added an additional sentence around hbase/solr.
As near as I can tell, the change doesn't affect new installations, only existing that are upgrading. The only thing that will likely need to be done will be a full reindex to handle the field name changes made to the constants file. Pierre On Thu, Apr 12, 2018 at 12:07 PM, Madhan Neethiraj <[email protected]> wrote: > Pierre, > > The review is in 'Discarded' state and no source file changes. > > I see a note on 'backwards incompatible' introduced in this patch. It is > not clear what the impact will be on existing deployments that use > HBase+Solr. Can you please add details? > > Thanks, > Madhan > > > > > On 4/12/18, 9:48 AM, "Pierre Padovani" <pierre.padovani@ > civitaslearning.com> wrote: > > Hey all, > > I submitted a review to fix the Elasticsearch support several weeks > ago, > and it has gotten no traction. > > https://reviews.apache.org/r/66064/ > > The current Elasticsearch support is severely broken, and cannot > function > with any of the currently support Elasticsearch versions for > JanusGraph. > This patch resolves those issues. > > Can someone please take a look at this and get it reviewed? This really > should make the 1.0.0 cut of Atlas. > > Thanks! > > Pierre Padovani > > > >
