----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66589/#review201043 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java Lines 51 (patched) <https://reviews.apache.org/r/66589/#comment281973> Default should be to retain the current behavior. I guess 'includeHadoopGroups' should be initialized to false for this? Please review. intg/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java Lines 54 (patched) <https://reviews.apache.org/r/66589/#comment281974> Replace 'true' with 'includeHadoopGroups', so that the default value set above will be used. - Madhan Neethiraj On April 12, 2018, 8:02 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66589/ > ----------------------------------------------------------- > > (Updated April 12, 2018, 8:02 p.m.) > > > Review request for atlas, Ashutosh Mestry and Madhan Neethiraj. > > > Bugs: ATLAS-2557 > https://issues.apache.org/jira/browse/ATLAS-2557 > > > Repository: atlas > > > Description > ------- > > This patch includes fix to allow to lookup hadoop ldap groups when group from > are wrongly set. > In this case reading groups from hadoop ldap group mapping can help to get > all groups. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java 09d8085c1 > > webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java > f77cb01d1 > > > Diff: https://reviews.apache.org/r/66589/diff/1/ > > > Testing > ------- > > Tested with property atlas.authentication.ugi-groups.include-hadoop-groups > set true and false. to verify the groups return are correct. > > > Thanks, > > Nixon Rodrigues > >
