----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66534/#review201058 -----------------------------------------------------------
Fix it, then Ship it! graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/AtlasGraphSONReader.java Lines 108 (patched) <https://reviews.apache.org/r/66534/#comment282016> Consider removing "Expected: " from the log message - in line #108 and #113. graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/GraphSONUtility.java Lines 47 (patched) <https://reviews.apache.org/r/66534/#comment282017> atlasbigIntegerTypeReference ==> bigIntegerType atlasBigDecimalTypeReference ==> bigDecimalType - Madhan Neethiraj On April 12, 2018, 8:29 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66534/ > ----------------------------------------------------------- > > (Updated April 12, 2018, 8:29 p.m.) > > > Review request for atlas, Madhan Neethiraj and Ruchi Solani. > > > Bugs: ATLAS-2555 > https://issues.apache.org/jira/browse/ATLAS-2555 > > > Repository: atlas > > > Description > ------- > > **Background** > Migration from HDP 2.6.x to HDP 3.x has a process based on GraphSON format. > > Add support for BigDecimal, BigInteger data types. > > **Implementation** > This patch contains unit tests for the module. > > General approach: > - JSON files for exports from older version are used as resources. > - Each of the key elements have a corresponding test. > > Description: > - _BaseUtils_: Base class from which all tests are derived. This has helper > methods to load various resources. > - _WorkItemManagerTest_: Simple usage. > > > Diffs > ----- > > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java > f252dc3e > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java > 2a1ce4e2 > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java > c9407bb4 > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/AtlasGraphSONReader.java > 099e6b9a > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/GraphSONTokensTP2.java > e8b07582 > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/GraphSONUtility.java > 51209354 > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/JsonNodeParsers.java > acf8cb2b > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/JsonNodeProcessManager.java > c1e9d204 > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/MappedElementCache.java > fe9e3272 > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/PostProcessManager.java > 4c5e357a > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/ReaderStatusManager.java > 67dbf225 > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/RelationshipTypeCache.java > 48b35958 > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/pc/WorkItemConsumer.java > 5de8db9a > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/pc/WorkItemManager.java > 7e21495d > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/BaseUtils.java > PRE-CREATION > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/GraphSONUtilityPostProcessTest.java > PRE-CREATION > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/GraphSONUtilityTest.java > PRE-CREATION > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/JsonNodeParsersTest.java > PRE-CREATION > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/MappedElementCacheTest.java > PRE-CREATION > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/ReaderStatusManagerTest.java > PRE-CREATION > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/WorkItemConsumerTest.java > PRE-CREATION > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/WorkItemManagerTest.java > PRE-CREATION > graphdb/janus/src/test/resources/atlas-migration-data.json PRE-CREATION > graphdb/janus/src/test/resources/col-legacy.json PRE-CREATION > graphdb/janus/src/test/resources/db-type-legacy.json PRE-CREATION > graphdb/janus/src/test/resources/db-v-65544.json PRE-CREATION > graphdb/janus/src/test/resources/edge-legacy.json PRE-CREATION > graphdb/janus/src/test/resources/table-v-147504.json PRE-CREATION > > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java > 82a800e8 > > repository/src/main/java/org/apache/atlas/repository/impexp/MigrationProgressService.java > 1daf371d > > repository/src/main/java/org/apache/atlas/repository/migration/DataMigrationService.java > 2fad333d > > repository/src/test/java/org/apache/atlas/repository/migration/MigrationBaseAsserts.java > 5639b430 > > repository/src/test/java/org/apache/atlas/repository/migration/MigrationProgressServiceTest.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/migration/PathTest.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/migration/RelationshipMappingTest.java > 0be4be8f > repository/src/test/resources/path_db/atlas-migration-data.json > PRE-CREATION > repository/src/test/resources/path_db/atlas-migration-typesdef.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/66534/diff/2/ > > > Testing > ------- > > **Unit tests** > New tests added. > > Build with tests. > Pre-commit build test. > > > Thanks, > > Ashutosh Mestry > >
