> On April 18, 2018, 5 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java > > Line 26 (original), 26 (patched) > > <https://reviews.apache.org/r/66653/diff/1/?file=2004975#file2004975line26> > > > > Would the following be efficient, which avoids having to pass a large > > list of types (and T.in check on each vertex)? > > g.V().has('__typeName').has('__state', > > 'ACTIVE').values('__typeName').groupCount() > > > > Similarly for line #29 below: > > g.V().has('__typeName').has('__state', > > 'DELETED').values('__typeName').groupCount()
This query issues a warning that a full graph scan, hence the within clause - Apoorv ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66653/#review201386 ----------------------------------------------------------- On April 18, 2018, 6:07 a.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66653/ > ----------------------------------------------------------- > > (Updated April 18, 2018, 6:07 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-2578 > https://issues.apache.org/jira/browse/ATLAS-2578 > > > Repository: atlas > > > Description > ------- > > Updated the business logic around metrics collection to allow faster > collection of metrics > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetrics.java > cfccc96c3 > repository/src/main/java/org/apache/atlas/services/MetricsService.java > 0fa68b257 > > repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java > 1eb7323ce > > repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java > 72b7261dd > > repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java > cca80b5ff > repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java > bdc0f0327 > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > b648bc1e6 > > > Diff: https://reviews.apache.org/r/66653/diff/3/ > > > Testing > ------- > > PreCommit: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/278/ > > > Thanks, > > Apoorv Naik > >
