----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66713/#review201520 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On April 19, 2018, 1:37 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66713/ > ----------------------------------------------------------- > > (Updated April 19, 2018, 1:37 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2587 > https://issues.apache.org/jira/browse/ATLAS-2587 > > > Repository: atlas > > > Description > ------- > > This patch add read ACL on /apache_atlas/active_server_info znode, so that > knox proxy get read access while in HA to get the active node URL. > > So the permission on on */apache_atlas/active_server_info* znode will be. > > [zk: zk:2181(CONNECTED) 2] getAcl /apache_atlas/active_server_info > 'world,'anyone > : r > 'sasl,'atlas > : cdrwa > > > Diffs > ----- > > webapp/src/main/java/org/apache/atlas/web/service/ActiveInstanceState.java > ea8b7388 > > webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceStateTest.java > 25f39f29 > > > Diff: https://reviews.apache.org/r/66713/diff/1/ > > > Testing > ------- > > Verify that permission are set to world:anyone:r along with sasl:atlas:cdrwa > on secure mode in HA. > The active-passive toggle is happening correctly. > > Verified on non secure mode. ACL 'world,'anyone: cdrwa is setting correctly. > > Atlas UI with knox-proxy is loading correctly, even after swithching from > active to passive and vice-versa. > > > Thanks, > > Nixon Rodrigues > >