----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66722/#review201564 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java Lines 210 (patched) <https://reviews.apache.org/r/66722/#comment282861> Why is it necessary to add this condition here? CollectionUtils.isNotEmpty(superTypes). Also, consider adding boolean field AtlasEntityType.isInternalType; and initialize it in resolveReferencesPhase3(). It will be efficient. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java Lines 289 (patched) <https://reviews.apache.org/r/66722/#comment282863> Consider reusing AtlasEntityType.isInternalType(), instead of looking for "__Atlas" prefix. Hint: instanceConverter has a reference to AtlasTypeRegistry. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java Lines 742 (patched) <https://reviews.apache.org/r/66722/#comment282872> Consider reusing AtlasEntityType.isInternalType(), instead of looking for super-type "__internal" repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java Lines 688 (patched) <https://reviews.apache.org/r/66722/#comment282867> To be consistent, use { } even for single statement blocks. - Madhan Neethiraj On April 19, 2018, 8:16 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66722/ > ----------------------------------------------------------- > > (Updated April 19, 2018, 8:16 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-2582 > https://issues.apache.org/jira/browse/ATLAS-2582 > > > Repository: atlas > > > Description > ------- > > Update deleteHandler implementation to force hard delete of the internal types > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 28054efc4 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 48db65792 > > repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AbstractGlossaryDTO.java > 722a463f6 > > repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryCategoryDTO.java > b26ee76cc > > repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java > e3786601d > > repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java > 92bb242a4 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java > e3f6f884e > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > c00015eb7 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 23ffdcd1f > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java > 29518c405 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java > c2f7c710b > repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java > 6deef800c > > > Diff: https://reviews.apache.org/r/66722/diff/1/ > > > Testing > ------- > > PreCommit: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/291/ > > > Thanks, > > Apoorv Naik > >
