-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66791/
-----------------------------------------------------------

(Updated April 25, 2018, 5:49 p.m.)


Review request for atlas, Madhan Neethiraj and Sarath Subramanian.


Changes
-------

Updates include: Addressed review comments.


Bugs: ATLAS-2602
    https://issues.apache.org/jira/browse/ATLAS-2602


Repository: atlas


Description
-------

**Background**
During entity creation, has a pre-create phase that discovers entities that 
need to be created within _AtlasEntity_. For import, this discovery was 
ignoring the entities present within relationship attribute.

**Fix**
The fix removes the condition.


Diffs (updated)
-----

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java
 f092d1847 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java
 af310954f 
  
repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java
 91d56ab80 
  repository/src/test/resources/stocks-glossary.zip PRE-CREATION 


Diff: https://reviews.apache.org/r/66791/diff/3/

Changes: https://reviews.apache.org/r/66791/diff/2-3/


Testing
-------

**Unit tests**
- New unit tests cover this case.
- Additional checks added using EntityDiscovery to query the Graph with known 
guids after import succeeds.


Thanks,

Ashutosh Mestry

Reply via email to