----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66918/#review202326 -----------------------------------------------------------
Ship it! Ship It! - Sarath Subramanian On May 2, 2018, 3:35 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66918/ > ----------------------------------------------------------- > > (Updated May 2, 2018, 3:35 p.m.) > > > Review request for atlas, Madhan Neethiraj and Sarath Subramanian. > > > Bugs: ATLAS-2624 > https://issues.apache.org/jira/browse/ATLAS-2624 > > > Repository: atlas > > > Description > ------- > > **Background** > Associating multiple tags to entity causes incorrect entity guid present in > the tag. > > E.g. > ```java > entityStore.addClassifications(dbEntityGuid, addedClassifications); > entityStore.addClassifications(tblEntityGuid, addedClassifications); > ``` > > This causes the guid of _dbEntityGuid_ to be present in classifications for > entity obtained by _tblEntityGuid_. > > The problem can be circumvented by creating a copy of the > _addedClassifications_ and passing it to 2nd call. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java > f73f36e2e > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > dbcf06a36 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java > 5d0892407 > > repository/src/test/java/org/apache/atlas/repository/tagpropagation/ClassificationPropagationTest.java > 51e40f0a6 > > > Diff: https://reviews.apache.org/r/66918/diff/2/ > > > Testing > ------- > > **Unit tests** > - Additional tests added to check this case. > - Updated _ClassificationPropagationTest_ for this condition. > > > Thanks, > > Ashutosh Mestry > >
