----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66899/#review202459 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On May 4, 2018, 4:33 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66899/ > ----------------------------------------------------------- > > (Updated May 4, 2018, 4:33 p.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-2634 > https://issues.apache.org/jira/browse/ATLAS-2634 > > > Repository: atlas > > > Description > ------- > > **Approach** > Simplified approach. > > **Algorithm** > - Modified: _NotificationHookConsumer_: > - when commit() fails, record current offset of the message. > - on receiving a message > - if _offset_ is same as that of the received message, skip processing > the message, go ahead and commit. > - reset recorded offset. > Added appropriate log messages. > > **Additional Refactoring** > None. > > > Diffs > ----- > > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java > 80dc51423 > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > 7a4596a7e > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java > d2b3dfdab > > > Diff: https://reviews.apache.org/r/66899/diff/5/ > > > Testing > ------- > > **Unit tests** > Additional unit tests to test specific scenarios. > > > Thanks, > > Ashutosh Mestry > >
