-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67001/
-----------------------------------------------------------

Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Abhay 
Kulkarni, Mehul Parikh, Nixon Rodrigues, Ruchi Solani, and Sarath Subramanian.


Bugs: ATLAS-2656
    https://issues.apache.org/jira/browse/ATLAS-2656


Repository: atlas


Description
-------

- replaced AtlasEntity used in entity notifications with AtlasEntityHeader 
(which includes fewer attributes), which can improve performance - especially 
for entities having large number of attributes or attributes having large 
array/map (like a hive_table containing 1000s of columns).
- updated attribute-def with addition of 'includeInNotification' flag, which 
can be used to specify if the attribute should be included in the notificaiton. 
By default, all unique-attributes of the entity will be included in the 
notification.
- moved EntityNotificationV2 from org.apache.atlas.v1.model.notification 
package to org.apache.atlas.model.notification.EntityNotificaiton


Diffs
-----

  addons/models/1000-Hadoop/1020-fs_model.json 1d7e9d3a1 
  addons/models/1000-Hadoop/1030-hive_model.json 68a5c849d 
  addons/models/1000-Hadoop/1060-hbase_model.json ec8dd4a40 
  addons/models/1000-Hadoop/1070-kafka_model.json 9ddc379f8 
  addons/models/1000-Hadoop/1080-storm_model.json b008c7ab2 
  
intg/src/main/java/org/apache/atlas/model/notification/EntityNotification.java 
f70eb3f00 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
a4c707a91 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 1b6af94f2 
  intg/src/main/java/org/apache/atlas/utils/AtlasJson.java 7d65bb646 
  
intg/src/main/java/org/apache/atlas/v1/model/notification/EntityNotificationV2.java
 a8dfd235a 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java 94242adcc 
  
repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java
 eb58b5e4b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
 44fb95fd2 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java
 26f3165df 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
 b46a1b776 
  
webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
 ab17ae41e 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
6f6a7ee9b 
  
webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java
 5ee8d30b7 


Diff: https://reviews.apache.org/r/67001/diff/1/


Testing
-------

- all UTs and ITs passed successfully - 
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/356/
- verified that the notifications include all unique attributes and attributes 
having includeInNotification=true


Thanks,

Madhan Neethiraj

Reply via email to