----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67033/#review202773 -----------------------------------------------------------
addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java Line 186 (original), 186 (patched) <https://reviews.apache.org/r/67033/#comment284766> Instead of making these methods 'public', consider making them package-private (i.e. remove public) and mark them with @VisibleForTesting. This would require the test class to be in the same package as this class. addons/kafka-bridge/src/test/resources/policy-store.txt Lines 1 (patched) <https://reviews.apache.org/r/67033/#comment284769> policy-store.txt shouldn't be needed any more. After introduction of new authorization mode, policy-store.txt is replaced by atlas-simple-authz-policy.json. - Madhan Neethiraj On May 9, 2018, 5:19 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67033/ > ----------------------------------------------------------- > > (Updated May 9, 2018, 5:19 p.m.) > > > Review request for atlas, Madhan Neethiraj and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > ATLAS-2666:Add unit test to KafkaBridge > > > Diffs > ----- > > addons/kafka-bridge/pom.xml 52f90d6 > > addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java > da6e7b9 > > addons/kafka-bridge/src/test/java/org/apache/atlas/kafka/KafkaBridgeTest.java > PRE-CREATION > addons/kafka-bridge/src/test/resources/atlas-application.properties > PRE-CREATION > addons/kafka-bridge/src/test/resources/atlas-log4j.xml PRE-CREATION > addons/kafka-bridge/src/test/resources/policy-store.txt PRE-CREATION > addons/kafka-bridge/src/test/resources/users-credentials.properties > PRE-CREATION > > > Diff: https://reviews.apache.org/r/67033/diff/1/ > > > Testing > ------- > > 1) Added unit test > 2) No Integration test for this now, so skipped that. > 3) This patch addresses the exceptions in Kafka bridge module build. > > > Verified in PRE-COMMIT > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/362/console > > > Thanks, > > Ramesh Mani > >
