> On May 4, 2018, 12:04 p.m., David Radley wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java > > Line 384 (original), 389 (patched) > > <https://reviews.apache.org/r/66949/diff/1/?file=2016734#file2016734line389> > > > > I suggest adding a comment here, around why you are checking for '-' as > > the first character. > > > > What happens if another repository creates an identifier starting with > > a '-' character? > > > > to cope with theis case - I am suggest that the logic should check for > > a null homeId and a guid starting character of '-' (or null) we should say > > the guid is not assigned. > > Graham Wallis wrote: > I like that - I wrote the GUID handling change before adding the homeId > system attribute. We could (now) include a check for homeId (not null) in the > GUID validity checking.
Actually when I came to implement this I discovered that it would require a pervasive change to Atlas (for example, isAssignedGuid would need to accept the homeId for any objects that possess it, which would affect all the callers of isAssignedGuid). So instead I have added a comment explaining the current checking and that it should be enhanced only if the requirement arises to support objects from a repository that assigns GUIDs prefixed with the '-' character. If such a requirement arises it might alternatively be possible to solve the requirement in the OMRS layer rather than inside Atlas - this could be evaluated at the time. - Graham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66949/#review202433 ----------------------------------------------------------- On May 10, 2018, 1:11 p.m., Graham Wallis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66949/ > ----------------------------------------------------------- > > (Updated May 10, 2018, 1:11 p.m.) > > > Review request for atlas, Ashutosh Mestry and Madhan Neethiraj. > > > Repository: atlas > > > Description > ------- > > ATLAS-2523: Changes to accept external GUIDs and manage homeIds > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java 3732556ae > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java > 7f36a10f5 > intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java > d04daa5d2 > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 6c0fdbf36 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 7490a15b1 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java > 9fcba6dda > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > cd00639de > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 183a2f6c0 > > > Diff: https://reviews.apache.org/r/66949/diff/2/ > > > Testing > ------- > > Functional testing of these changes to save reference copies of entities and > relationships > > > Thanks, > > Graham Wallis > >
