----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67060/#review202903 -----------------------------------------------------------
distro/src/main/assemblies/omag-server.xml Lines 29 (patched) <https://reviews.apache.org/r/67060/#comment284944> I am wondering if you should add <fileMode> and <directoryMode> like KafkaHook does. We should ensure that the jar and sh files are executable and the readme is not. I see -rw-r--r-- 1 david staff 1080 11 May 09:48 README.md -rw-r--r-- 1 david staff 8022 11 May 09:55 omag-server-1.0.0-SNAPSHOT-sources.jar -rw-r--r-- 1 david staff 6561 11 May 09:55 omag-server-1.0.0-SNAPSHOT-test-sources.jar -rw-r--r-- 1 david staff 17222951 11 May 09:55 omag-server-1.0.0-SNAPSHOT.jar It doesn to look like the jar is executable. Also why have we got the sources and test sources jar files? distro/src/main/assemblies/omag-server.xml Lines 38 (patched) <https://reviews.apache.org/r/67060/#comment284948> I see none of the other assemblies use ../ I am not sure why we need to? omag-server/README.md Lines 22 (patched) <https://reviews.apache.org/r/67060/#comment284946> I suggest changing this to be launching the standalone Open Metadata And Governance (OMAG) Server. omag-server/README.md Lines 25 (patched) <https://reviews.apache.org/r/67060/#comment284945> If you lose this whitespace - then we will not get thew white space warning on patch apply omag-server/pom.xml Line 124 (original), 124 (patched) <https://reviews.apache.org/r/67060/#comment284947> I do not understand this change. How does this effect the Atlas build? - David Radley On May 10, 2018, 4:23 p.m., Nigel Jones wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67060/ > ----------------------------------------------------------- > > (Updated May 10, 2018, 4:23 p.m.) > > > Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and > Mandy Chessell. > > > Repository: atlas > > > Description > ------- > > Added OMAG Server to distribution with an easy to launch jar > (See JIRA for more information) > > > Diffs > ----- > > distro/pom.xml 6431fd86d > distro/src/main/assemblies/omag-server.xml PRE-CREATION > omag-server/README.md PRE-CREATION > omag-server/pom.xml 4c1c98aa3 > > > Diff: https://reviews.apache.org/r/67060/diff/1/ > > > Testing > ------- > > Built atlas > Checked correct files in distribution archive > Checked OMAG server launches with default config > > > Thanks, > > Nigel Jones > >
