> On May 11, 2018, 12:20 p.m., David Radley wrote: > > ATLAS-2668a.patch > > Lines 1 (patched) > > <https://reviews.apache.org/r/67060/diff/3/?file=2019930#file2019930line1> > > > > looks like a patch has got into the diff
Yes. My bad. I forgot to delete the patch when making the followon diff (it's not in the local git commit, so git-wise I look ok). Realised before the comment but you were too quick :-) Removed now. It's quite easy to make little mistakes like this with the tool but practice should help ... - Nigel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67060/#review202921 ----------------------------------------------------------- On May 11, 2018, 12:18 p.m., Nigel Jones wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67060/ > ----------------------------------------------------------- > > (Updated May 11, 2018, 12:18 p.m.) > > > Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and > Mandy Chessell. > > > Repository: atlas > > > Description > ------- > > Added OMAG Server to distribution with an easy to launch jar > (See JIRA for more information) > > > Diffs > ----- > > ATLAS-2668a.patch PRE-CREATION > distro/pom.xml 6431fd86d > distro/src/main/assemblies/omag-server.xml PRE-CREATION > omag-server/README.md PRE-CREATION > omag-server/pom.xml 4c1c98aa3 > > > Diff: https://reviews.apache.org/r/67060/diff/3/ > > > Testing > ------- > > Built atlas > Checked correct files in distribution archive > Checked OMAG server launches with default config > > > Thanks, > > Nigel Jones > >
