> On May 14, 2018, 11:25 a.m., Nigel Jones wrote: > > omag-api/pom.xml > > Line 46 (original) > > <https://reviews.apache.org/r/67083/diff/1/?file=2019867#file2019867line46> > > > > I wonder why we went with 1.5.7 of springboot? I know we want to match > > up SPRING versions (which maps to 4.x) > > > > Using the same version as atlas seems a good move, and this is 4.3.8 as > > defined in the top level pom.xml > > > > However 1.5.7 (used in this patch) of springbook maps to spring 4.3.11, > > whilst 1.5.3 maps to 4.3.8 (used in Atlas). > > > > I wonder if to eliminate issues we should match more closely - for > > example go with 1.5.3 of springboot. Alternatively bring Atlas up to the > > most current 1.5/4.x versions initially, maybe even 2.x/5.2 in the next > > release? > > Bogdan Sava wrote: > Springboot is now a dependency only on omag-server. It is not needed in > Atlas (I have removed all unused springboot dependencies). > As omag-server is independent of Atlas, I plan to upgrade to psringboot > 2.x > > omag-api, omases and omrs are using spring-web which is inherited from > atlas parent pom.
Ok, thanks, will check in next patch - Nigel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67083/#review203003 ----------------------------------------------------------- On May 14, 2018, 8 p.m., Bogdan Sava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67083/ > ----------------------------------------------------------- > > (Updated May 14, 2018, 8 p.m.) > > > Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy > Chessell, and Ruxandra Rosu. > > > Repository: atlas > > > Description > ------- > > Create configuration for OMAG API in Atlas > > > Diffs > ----- > > om-fwk-ocf/pom.xml 8b1cefd > omag-api/pom.xml 2338286 > > omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java > dd19018 > omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java > PRE-CREATION > > omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java > PRE-CREATION > > omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java > ebc9f2a > > omag-api/src/main/java/org/apache/atlas/omag/api/OMAGServerAdminResource.java > PRE-CREATION > omag-server/pom.xml 527c5c3 > > omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java > 88397de > omag-server/src/main/resources/application.properties PRE-CREATION > omas-assetconsumer/pom.xml 29935e7 > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/api/AssetConsumerOMASResource.java > PRE-CREATION > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java > 80a98f5 > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java > > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java > 967be5a > omas-connectedasset/README.md 2f431df > omas-connectedasset/pom.xml 219c972 > > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/api/ConnectedAssetOMASResource.java > PRE-CREATION > > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java > 8ae6c37 > omrs/pom.xml 50b9898 > > omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java > 7ae87c6 > omrs/src/main/java/org/apache/atlas/omrs/api/OMRSRepositoryResource.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java > 5948482 > > omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java > 3f85317 > > omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java > ccf0de6 > webapp/pom.xml 03b8408 > webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1 > webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION > webapp/src/main/webapp/WEB-INF/web.xml 23dc063 > > > Diff: https://reviews.apache.org/r/67083/diff/2/ > > > Testing > ------- > > Create configuration for OMAG API in Atlas using Spring MVC Dispatcher > servlet. > > > Change base URL for the API to "/open-metadata/access-services" > > > Clean maven unused dependenies > > The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665 > > > File Attachments > ---------------- > > Added apache licence to a properties file > > https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch > 0003-ATLAS-2665-comments-fixed.patch > > https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch > ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch > > https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch > > > Thanks, > > Bogdan Sava > >
