----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67089/#review203141 -----------------------------------------------------------
Hi David, I think what you have here will work correctly. Personally I find the 'rules' to be quite difficult to parse and correlate with the logic in the comments. Would it be possible to lay out the predicates more clearly, e.g. range checking 'element' within the array bounds and current size? - Graham Wallis On May 11, 2018, 2:56 p.m., David Radley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67089/ > ----------------------------------------------------------- > > (Updated May 11, 2018, 2:56 p.m.) > > > Review request for atlas, Graham Wallis and MandyDW MandyDW. > > > Bugs: ATLAS2674 > https://issues.apache.org/jira/browse/ATLAS2674 > > > Repository: atlas > > > Description > ------- > > Unable to set an array value for an attribute in the open metadata > > > Diffs > ----- > > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/ArrayPropertyValue.java > 154eb16c9 > > omrs/src/test/java/org/apache/atlas/omrs/metadatacollection/properties/instances/TestArrayPropertyValue.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/67089/diff/1/ > > > Testing > ------- > > Ran junits- that failed without the fix. > > > Thanks, > > David Radley > >
