----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67239/#review203543 -----------------------------------------------------------
Ship it! Ship It! - Ashutosh Mestry On May 21, 2018, 10:54 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67239/ > ----------------------------------------------------------- > > (Updated May 21, 2018, 10:54 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Nixon > Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-2710 > https://issues.apache.org/jira/browse/ATLAS-2710 > > > Repository: atlas > > > Description > ------- > > This is caused by entity-delete removing vertex property that stores > associated classification names. This property is used by basic-search to > look for entities, hence the deleted entity was not returned. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > f417b4e95 > > > Diff: https://reviews.apache.org/r/67239/diff/1/ > > > Testing > ------- > > Verified that basic-search returns deleted entities as well when > excludeDeletedEntities is False. > > > Thanks, > > Madhan Neethiraj > >