-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67273/#review203690
-----------------------------------------------------------




addons/models/0000-Area0/0010-base_model.json
Lines 240 (patched)
<https://reviews.apache.org/r/67273/#comment285963>

    Shouldn't this be COMPOSITION ? Saved search can't exist without a 
UserProfile or can it ?


- Apoorv Naik


On May 23, 2018, 8:20 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67273/
> -----------------------------------------------------------
> 
> (Updated May 23, 2018, 8:20 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2714
>     https://issues.apache.org/jira/browse/ATLAS-2714
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> - added relationship-def _AtlasUserProfile_savedsearches, to avoid WARN 
> messages in Atlas log file
> - updated few relationships to align end1/end2  with edge-direction: 
> dataset_process_inputs, hive_table_db, hbase_table_namespace
> - fixed cardinality of array attributes to LIST/SET (instead of SINGLE - 
> which causes confusion)
> 
> 
> Diffs
> -----
> 
>   addons/models/0000-Area0/0010-base_model.json fe8001915 
>   addons/models/1000-Hadoop/1030-hive_model.json 552dfe483 
>   addons/models/1000-Hadoop/1060-hbase_model.json 392412aec 
> 
> 
> Diff: https://reviews.apache.org/r/67273/diff/1/
> 
> 
> Testing
> -------
> 
> - verified that WARN message is no more present in Atlas log
> - verified that hive_db/hive_table entities CRUD & lineage work as before 
> (i.e. no regression due to model changes)
> - precommit test run: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/443/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Reply via email to