----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67275/#review203718 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java Lines 139 (patched) <https://reviews.apache.org/r/67275/#comment286006> Adding all attributes of the term in this audit log doesn't seem useful. Instead, having the following should be enough: - term guid - term name - term qualifiedName Currently audit log has all attributes of the term, including the following: - anchor - classifications - longDescription - shortDescription - assignedEntities repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java Lines 150 (patched) <https://reviews.apache.org/r/67275/#comment286007> Same comment as above (line #139). repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java Lines 178 (patched) <https://reviews.apache.org/r/67275/#comment286010> Consider renaming onTermAddedToEntities() to onTermAdded(), for consistency with other methods here. repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java Lines 187 (patched) <https://reviews.apache.org/r/67275/#comment286008> Same comment as for EntityAuditListener.onTermAdded() repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java Lines 196 (patched) <https://reviews.apache.org/r/67275/#comment286009> Consider renaming onTermDeletedFromEntities() to onTermDeleted(), for consistency with other methods here. repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java Lines 205 (patched) <https://reviews.apache.org/r/67275/#comment286011> Same comment as for EntityAuditListener.onTermDeleted() - Madhan Neethiraj On May 23, 2018, 10:04 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67275/ > ----------------------------------------------------------- > > (Updated May 23, 2018, 10:04 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2715 > https://issues.apache.org/jira/browse/ATLAS-2715 > > > Repository: atlas > > > Description > ------- > > No audit events are generated when term is associated or removed from entity. > This JIRA adds TERM_ADD and TERM_DELETE audit events. > > > Diffs > ----- > > client/client-v1/src/main/java/org/apache/atlas/EntityAuditEvent.java > 7077e1529 > dashboardv2/public/js/utils/Enums.js 1e493e52e > intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java > 9c735a075 > intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java > 787f5a9e5 > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java > a5499e07c > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java > a085e8e2d > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java > 970b14a1a > > repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java > 3656b8501 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java > 083600eae > > server-api/src/main/java/org/apache/atlas/listener/EntityChangeListener.java > ab379e083 > > tools/atlas-migration-exporter/src/main/java/org/apache/atlas/migration/NoOpNotificationChangeListener.java > 9af7819a6 > > webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java > 9de49d4cf > > webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java > dbdf67db7 > > > Diff: https://reviews.apache.org/r/67275/diff/1/ > > > Testing > ------- > > Precommit: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/446/console > > > Thanks, > > Sarath Subramanian > >
