Hi Madhan I don't mind either way - it should be safe to commit to 1.0, but on the other hand it is not needed until the Atlas OMRS connector is committed - which I imagine will be to master and not to 1.0. It is probably easier to make it master only, just due to not needing to double fix.
Best regards, Graham Graham Wallis IBM Analytics Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN Tel: +44 7741 379735 From: Madhan Neethiraj <mad...@apache.org> To: Graham Wallis <graham_wal...@uk.ibm.com> Cc: atlas <d...@atlas.incubator.apache.org>, Ashutosh Mestry <ames...@hortonworks.com> Date: 25/05/2018 14:40 Subject: Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds Graham, Please let me know if you need this commit to be included in 1.0 release. I am planning to send release-candidate for vote later today; and I see no harm in including this commit. Thanks, Madhan From: Madhan Neethiraj <nore...@reviews.apache.org> on behalf of Madhan Neethiraj <mad...@apache.org> Reply-To: Madhan Neethiraj <mad...@apache.org> Date: Friday, May 25, 2018 at 6:37 AM To: Ashutosh Mestry <ames...@hortonworks.com>, Madhan Neethiraj <mad...@apache.org> Cc: Graham Wallis <graham_wal...@uk.ibm.com>, atlas <d...@atlas.incubator.apache.org> Subject: Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66949/ Ship it! Ship It! - Madhan Neethiraj On May 25th, 2018, 12:47 p.m. UTC, Graham Wallis wrote: Review request for atlas, Ashutosh Mestry and Madhan Neethiraj. By Graham Wallis. Updated May 25, 2018, 12:47 p.m. Repository: atlas Description ATLAS-2523: Changes to accept external GUIDs and manage homeIds Testing Functional testing of these changes to save reference copies of entities and relationships Diffs common/src/main/java/org/apache/atlas/repository/Constants.java (6d95c459a) intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java (7f36a10f5) intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java (debaeeff6) intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java (6c0fdbf36) repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java (78ab206d3) repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java (3ca287209) repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java (eb1079c41) repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java (707ea343c) repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java (d5644f95d) View Diff Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
