----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67422/#review204219 -----------------------------------------------------------
addons/hbase-bridge/src/bin/import-hbase.sh Line 130 (original), 129 (patched) <https://reviews.apache.org/r/67422/#comment286623> Instead of specifically looking for "-D", consider the following to collect arguments for the import tool in IMPORT_ARGS and the rest in JVM_ARGS: #!/bin/bash IMPORT_ARGS= JVM_ARGS= while true do option=$1 shift case "$option" in -d) IMPORT_ARGS="$IMPORT_ARGS -d $1"; shift;; -t) IMPORT_ARGS="$IMPORT_ARGS -t $1"; shift;; --database) IMPORT_ARGS="$IMPORT_ARGS --database $1"; shift;; --table) IMPORT_ARGS="$IMPORT_ARGS --table $1"; shift;; "") break;; *) JVM_ARGS="$JVM_ARGS $option" esac done echo JVM_ARGS=$JVM_ARGS echo IMPORT_ARGS=$IMPORT_ARGS - Madhan Neethiraj On June 2, 2018, 1:31 a.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67422/ > ----------------------------------------------------------- > > (Updated June 2, 2018, 1:31 a.m.) > > > Review request for atlas, Madhan Neethiraj and Nixon Rodrigues. > > > Bugs: ATLAS-2732 > https://issues.apache.org/jira/browse/ATLAS-2732 > > > Repository: atlas > > > Description > ------- > > ATLAS-2732:Handle kerberos security arguments in import-hbase.sh / > import-hive.sh passed via command line > > > Diffs > ----- > > addons/hbase-bridge/src/bin/import-hbase.sh 0a5989f > addons/hive-bridge/src/bin/import-hive.sh 98f4c84 > > > Diff: https://reviews.apache.org/r/67422/diff/1/ > > > Testing > ------- > > Tested in Local VM > > > Thanks, > > Ramesh Mani > >
