----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67410/#review204220 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/util/DateTimeUtil.java Lines 36 (patched) <https://reviews.apache.org/r/67410/#comment286624> - ValidateTimeBoundry() ==> validateTimeBoundry() - replace startDate/endDate/timeZonStr with "TimeBoundary timeBoundary" repository/src/main/java/org/apache/atlas/util/DateTimeUtil.java Lines 39 (patched) <https://reviews.apache.org/r/67410/#comment286625> startDate and endDate can be null. It is not an error condition. Only validation required is that, when both values are specified, startDate should not be later than endDate. repository/src/main/java/org/apache/atlas/util/DateTimeUtil.java Lines 44 (patched) <https://reviews.apache.org/r/67410/#comment286626> timeZone can be null or empty - which is treated as local-timezone. - Madhan Neethiraj On June 1, 2018, 12:29 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67410/ > ----------------------------------------------------------- > > (Updated June 1, 2018, 12:29 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, > Ruchi Solani, and Sarath Subramanian. > > > Bugs: ATLAS-2730 > https://issues.apache.org/jira/browse/ATLAS-2730 > > > Repository: atlas > > > Description > ------- > > This patch includes validation of classifcation TimeBoundry date time > timezone during addclassification and updateClassifcation of entity. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 06b43458b > repository/pom.xml a6ee43f61 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > 5e33cf59f > repository/src/main/java/org/apache/atlas/util/DateTimeUtil.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/67410/diff/1/ > > > Testing > ------- > > Tested adding / updating classifcation with / invalid / without > TimeBoundry/datetime timezeone from UI and from API. > Existing UT and IT passing. > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/462/console > > > Thanks, > > Nixon Rodrigues > >
