----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67499/#review204493 -----------------------------------------------------------
Ship it! Ship It! - Sarath Subramanian On June 8, 2018, 3:31 a.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67499/ > ----------------------------------------------------------- > > (Updated June 8, 2018, 3:31 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2730 > https://issues.apache.org/jira/browse/ATLAS-2730 > > > Repository: atlas > > > Description > ------- > > Currently, timezone which is not null and not valid was treated as default > system timezone. > > This patch (ATLAS-2730-4.patch) adds validation for timezone to accept > timezone in valid format. > > eg:- > > JST,IND,UTC > GMT+0 > GMT+10:30 > GMT-13 > America/Los_Angeles > Asia/Singapore > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f0585ebe1 > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > 1adb362dd > intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java > 1ade5f704 > > > Diff: https://reviews.apache.org/r/67499/diff/1/ > > > Testing > ------- > > Performed manual testing by adding valid and invalid timezone in > classification > Added test unittestcases > > > Thanks, > > Nixon Rodrigues > >
