----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67514/#review204516 -----------------------------------------------------------
Would it help to update stop() to set consumer=null and producer=null? notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java Line 226 (original), 226 (patched) <https://reviews.apache.org/r/67514/#comment287037> "consumer != null" doesn't seem necessary here. notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java Lines 298 (patched) <https://reviews.apache.org/r/67514/#comment287035> Consider reading this string from a configuration - like: atlas.kafka.error.message.consumer_closed=This consumer has already been closed." This can handling of Kafka message changes easier. - Madhan Neethiraj On June 8, 2018, 10:50 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67514/ > ----------------------------------------------------------- > > (Updated June 8, 2018, 10:50 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Nixon Rodrigues. > > > Bugs: ATLAS-2751 > https://issues.apache.org/jira/browse/ATLAS-2751 > > > Repository: atlas > > > Description > ------- > > Atlas is not consuming messages from ATLAS_HOOK topic after recovering from > zookeeper connection timeout. > > > Diffs > ----- > > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java > 00e56e33f > > > Diff: https://reviews.apache.org/r/67514/diff/1/ > > > Testing > ------- > > Manually tested in HA cluster toggling active and passive state. consumers > process hook messages. > > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/474/console > > > Thanks, > > Sarath Subramanian > >
