----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67640/#review205247 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On June 19, 2018, 5:44 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67640/ > ----------------------------------------------------------- > > (Updated June 19, 2018, 5:44 a.m.) > > > Review request for atlas, Apoorv Naik, Madhan Neethiraj, Ruchi Solani, and > Sarath Subramanian. > > > Bugs: ATLAS-2761 > https://issues.apache.org/jira/browse/ATLAS-2761 > > > Repository: atlas > > > Description > ------- > > **Background** > Spring got integrated around mid-May of 2017 within Atlas code base. > > Existing implementation of _Migration Exporter_ uses Spring for instantiating > objects. While this is a clean approach, it prevents versions prior to May > 2017 from using _Migration Exporter_. > > **Approach** > - Removed use of Spring. > - Objects are directly instantiated. > - Constructor variations have been identified and care has been taken to > support that using Reflection. > > > Diffs > ----- > > tools/atlas-migration-exporter/pom.xml 8ecd306ff > > tools/atlas-migration-exporter/src/main/java/org/apache/atlas/migration/Exporter.java > 1bda19fb4 > tools/atlas-migration-exporter/src/main/resources/migrationContext.xml > c0f96598c > > > Diff: https://reviews.apache.org/r/67640/diff/1/ > > > Testing > ------- > > **Unit tests** > None. > > **Versions verified** > Versions prior to branch-0.8 creation have been verified. > > > Thanks, > > Ashutosh Mestry > >
