----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67741/#review205366 -----------------------------------------------------------
Ship it! Ship It! - Nixon Rodrigues On June 26, 2018, 1:42 p.m., Abhishek Kadam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67741/ > ----------------------------------------------------------- > > (Updated June 26, 2018, 1:42 p.m.) > > > Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and > Sarath Subramanian. > > > Bugs: ATLAS-2766 > https://issues.apache.org/jira/browse/ATLAS-2766 > > > Repository: atlas > > > Description > ------- > > When ATLAS-2765 will be in place, the search result will have “-1” as guid > for entities on which the user doesn’t have ‘entity-read’ permission. UI > will not hyperlink ‘Name’ column for such result entries. This will prevent > the user from clicking the link to go to entity details page and not able to > tag term/classification. > > > Diffs > ----- > > dashboardv2/public/js/views/search/SearchResultLayoutView.js 7fa088b > > > Diff: https://reviews.apache.org/r/67741/diff/1/ > > > Testing > ------- > > Verified for admin and rangertagsync user with type/classification policy on > entity, the entities with no access to type /classification where shown with > guid '-1' and hyperlink for this entities was disabled and tag > term/classification button are disabled. > > Performed sanity UI test. > > > Thanks, > > Abhishek Kadam > >
