----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67797/#review205617 -----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java Line 128 (original), 128 (patched) <https://reviews.apache.org/r/67797/#comment288488> Instead of @QueryParam, consider looking for 'excludeInternalTypesAndReferences' in getSearchFilter() to decide whether to apply internal-type filter or not. Also, the param should not be included in the SearchFilter returned from getSearchFilter(). - Madhan Neethiraj On July 2, 2018, 12:21 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67797/ > ----------------------------------------------------------- > > (Updated July 2, 2018, 12:21 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Nixon Rodrigues. > > > Bugs: ATLAS-2771 > https://issues.apache.org/jira/browse/ATLAS-2771 > > > Repository: atlas > > > Description > ------- > > Add option to exclude internal types when using GET all types using > getAllTypeDefs() > > > Diffs > ----- > > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 345250a34 > > > Diff: https://reviews.apache.org/r/67797/diff/1/ > > > Testing > ------- > > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/493/console > > > Thanks, > > Sarath Subramanian > >
