----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67785/#review205646 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On June 29, 2018, 1:23 p.m., Abhishek Kadam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67785/ > ----------------------------------------------------------- > > (Updated June 29, 2018, 1:23 p.m.) > > > Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues. > > > Bugs: ATLAS-2767 and ATLAS-2768 > https://issues.apache.org/jira/browse/ATLAS-2767 > https://issues.apache.org/jira/browse/ATLAS-2768 > > > Repository: atlas > > > Description > ------- > > Steps to reproduce:- > 1.Go to Classification tab and click on create button > 2.Now enter classification name and click on Add Attribute button > 3.Now don't enter any attribute name and click on create button - error > message will appears as "Please fill the attributes or delete the input box" > 4.Now click on "X" button of attribute > > Expected:- > Create button would be enabled > > Error:- > Create button is not enabled which is incorrect > > Fix Detail: This patch includes fix for ATLAS-2767 and ATLAS-2768 > > > Diffs > ----- > > dashboardv2/public/js/views/tag/TagAttributeItemView.js 3ce40e2 > dashboardv2/public/js/views/tag/TagLayoutView.js c7a5edb > > > Diff: https://reviews.apache.org/r/67785/diff/1/ > > > Testing > ------- > > Did sanity testing with deleting classifications from classification tree > Tested the add attribute while adding classification. > > > Thanks, > > Abhishek Kadam > >
