-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60857/
-----------------------------------------------------------

(Updated July 10, 2018, 5:08 p.m.)


Review request for atlas, Ayub Pathan and Madhan Neethiraj.


Changes
-------

Updates include: Re-based against latest _branch-0.8_.


Bugs: ATLAS-1950
    https://issues.apache.org/jira/browse/ATLAS-1950


Repository: atlas


Description
-------

**Background**
Existing import transforms expects that the user specify each type and 
attribute name that needs to be transformed. This may cause large number of 
transform enumerating individual types to be specified. Specifying individual 
transforms may be tedious and perhaps error prone.

**Solution**
This feature improves on that case by allowing user to specify super types. 
That way the sub types of that type will automatically get the transform(s) 
applied.

**Implementation**
User can now specify transforms like:

```javascript
{
    "options": {
        "transforms": "{ \"Asset\": { \"qualifiedName\": [ 
\"replace:@cl1:@cl2\" ] } }"
    }
}
```

At runtime, the subtypes of this type are enumerated. The attribute and 
tranform map of the super type are now associated with all the sub-types.


Diffs (updated)
-----

  
repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java 
c976c593e 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransforms.java
 63e53c50e 
  
repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java
 035ddac6d 
  
repository/src/test/java/org/apache/atlas/repository/impexp/ImportTransformsTest.java
 ccedeb144 


Diff: https://reviews.apache.org/r/60857/diff/4/

Changes: https://reviews.apache.org/r/60857/diff/3-4/


Testing
-------

**Unit tests**
Unit test verifying this behavior were added.

**Functional tests**
Regular imports were run.


Thanks,

Ashutosh Mestry

Reply via email to