----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68172/#review206824 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/impexp/AtlasExportRequest.java Line 51 (original), 51 (patched) <https://reviews.apache.org/r/68172/#comment289908> updateMetaInfo - this name is not intutive. Is this used to decide whether to update attribute 'replicatedFromCluster' (during import) or 'replicatedToCluster' (during export)? repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java Lines 99 (patched) <https://reviews.apache.org/r/68172/#comment289909> since startTime and endTime are passed as parameters, is it necessary to send duration as well? repository/src/main/java/org/apache/atlas/repository/impexp/MetaInfoService.java Lines 41 (patched) <https://reviews.apache.org/r/68172/#comment289907> MetaInfoService seems to be a wrapper around ExportImportAuditService, with added functionality to handle creation of 'cluster' entity. It will be cleaner to handle this in ExportImportAuditService itself and eliminate MetaInfoService. If MetaInfoService is critical, both ExportImportAuditService and ClusterService should not be visible outside repository module - to prevent anyone from using these 2 services directly. - Madhan Neethiraj On Aug. 2, 2018, 8:36 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68172/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2018, 8:36 p.m.) > > > Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-2804 > https://issues.apache.org/jira/browse/ATLAS-2804 > > > Repository: atlas > > > Description > ------- > > **Approach** > New class MetaInfoService calls the _ExportImportAuditService_ with right > parameters. Default _AtlasCluster_ entity gets created. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/impexp/AtlasExportRequest.java > f1ed822106c7f06138c7e24aac0cab269fea6b9a > intg/src/main/java/org/apache/atlas/model/impexp/AtlasExportResult.java > 8f3075e3d571e4817cef443d0f74f194c0eb860a > intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java > 304ec5d84d2542b067a4f792c796e9c715fabc11 > > repository/src/main/java/org/apache/atlas/repository/clusterinfo/ClusterService.java > 0e23374745dc86d34165768c876a51a5c6f217a1 > > repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java > ce792e0a2d61bf52ee84a47107645c572df71765 > > repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java > 972e1e358380509a92280cd28e09ac0314fd2468 > > repository/src/main/java/org/apache/atlas/repository/impexp/MetaInfoService.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/impexp/ExportImportTestBase.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java > 8b68bba241249e3630be16f454e9f7220b421bd0 > > repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java > c03fbc61498f60c777881848b57d7219335c5162 > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 4224bb161c39cde3baf59fab2d12f53bbb1c051c > > > Diff: https://reviews.apache.org/r/68172/diff/1/ > > > Testing > ------- > > **Tests** > > Unit tests updated to check for Audits. > > > Thanks, > > Ashutosh Mestry > >
