----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68188/#review207015 -----------------------------------------------------------
common/src/main/java/org/apache/atlas/repository/Constants.java Lines 96 (patched) <https://reviews.apache.org/r/68188/#comment290179> I suggest a comment to document what the flag is. In the style of the homeId comment. repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Lines 174 (patched) <https://reviews.apache.org/r/68188/#comment290180> I am wondering what your thoughts are on validation in Atlas. Specifically for cases like: - the entity is a proxy but has no homeid. - the entity is a proxy but has none manditory attributes set which should not be returned - the entity is a proxy so should not be in search results As coded the caller is responsible for this sort of validation. - David Radley On Aug. 3, 2018, 1:33 p.m., Graham Wallis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68188/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2018, 1:33 p.m.) > > > Review request for atlas. > > > Repository: atlas > > > Description > ------- > > ATLAS_2808: Support for entity proxies > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java > 7988d1d81595eb3d65ecca2480c0e67d17f53573 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java > dc2be412b9ec1b07d7c7befc722810273464cd3f > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > d328873f1f2695954d79e476a40166f48ffda482 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > f57ce99f764a5c779f1cfa4325849c15ac804b2d > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 448d03bc069869db85cd86e14021a3fa59b57e33 > > > Diff: https://reviews.apache.org/r/68188/diff/1/ > > > Testing > ------- > > Tested with saveRelationshipReferenceCopy between entities that do not exist > in the Atlas repository. > > > Thanks, > > Graham Wallis > >
